Merge pull request #263 from puppetlabs/maint_modsync_1d81b6a
(maint) - modulesync 1d81b6a
(MODULES-6068) Make management of /etc/pki directory optional (#252)
Make management of /etc/pki directory optional. Added comment explaining the manage_pki_dir option. Added spec tests for manage_pki_dir parameter.
(MODULES-5637) Fix version tag on Amazon Linux (#249)
While the EL6 packages work for Amazon Linux (https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/1.4.1/manifests/osfamily/redhat.pp#L9-L10), I get this error when ensuring a package version. ``` Error: Could not update: Failed to update to version 5.1.0-1.el2017, got version 5.1.0-1.el6 instead Error: /Stage[main]/Puppet_agent::Install/Package[puppet-agent]/ensure: change from '5.1.0-1.el6' to '5.1.0-1.el2017' failed: Could not update: Failed to update to version 5.1.0-1.el2017, got version 5.1.0-1.el6 instead ``` This PR fixes that.
(maint) Disable PuppetLint i18n check
While we support Puppet 3, we can't use puppetlabs-translate as it uses Puppet 4 functions. Disable the i18n check in PuppetLint that requires messages to be decorated with the translation function.
Merge pull request #264 from MikaelSmith/disable-i18n-check
(maint) Disable PuppetLint i18n check
Merge pull request #265 from gguillotte/MODULES-6095
(MODULES-6095) Review docs for release.
Merge pull request #267 from puppetlabs/release
Merge 1.5.0 release back into master
Merge pull request #269 from puppetlabs/maint_modsync_384f4c1
(maint) - modulesync 384f4c1
(MODULES-6280) ensure compatibility to puppetlabs/apt > 3.0.0 (#268)
* increase max. version number of dependency puppetlabs/apt to 4.1.0 * add testfacts for compatibility to puppetlabs/apt >= 3.0.0
Merge pull request #270 from michaeltlombardi/modsync
(maint) modulesync cd884db Remove AppVeyor OpenSSL update on Ruby 2.4
Merge pull request #272 from ekinanp/PE-23542
(PE-23542) Add OSX 10.13
Merge pull request #273 from ekinanp/PE-23558
(PE-23558) Add RHEL 7 AARCH64
(PE-23563) Stop MCO prior to initiating MSI install
Previously it was possible to get into a strange race condition where the MSI was able to propertly stop the MCollective service prior to upgrade. This commit attempts to stop the mco service prior to the MSI being invoked, giving the service more time to stop correctly.
(PE-23563) Stop Puppet prior to MSI install
Previously it was possible to get into a strange race condition where the MSI was able to propertly stop the Puppet Agent service prior to upgrade. This commit attempts to stop the puppet service prior to the MSI being invoked, giving the service more time to stop correctly.
(maint) Dump token privileges for current user
Previously it was difficult to debug failed upgrades as it was not possible to know what rights the installation user had at install time. This commit logs the current user's rights prior to the upgrade.
(MODULES-6686) Fix puppet_agent_spec tests for Windows
Previously many tests in classes/puppet_agent_spec.rb were not running on Windows due to a bug in rspec-puppet-facts. However in v1.9.0 of the gem it now adds better windows support, but the puppet_agent_spec.rb began running tests for Windows which then failed. This commit modifies the test fixtures and logic to only test things which make sense on Windows. Also voxpupuli/rspec-puppet-facts#68 meant that the order of the testing had to be determinstic, ensuring that Windows platforms were tested last.
Merge pull request #275 from glennsarti/fix-broke-stuff
(MODULES-6686) Fix puppet_agent_spec tests for Windows
(MODULES-6688) Updatd Travis CI testing to supercede Jenkins
Previously the module was tested in both Travis and private Jenkins CI systems however this is no longer required. This commit moves the spec tests that are tested in Jenkins and moves them to Travis; * Only test puppet agent and ruby combinations that are installed in AIO installs * Split out validate and lint checking to only happen once per job not for all matrix cells * Now tests on Puppet latest 3.8, first 4.0, latest 4.7.x, 4.10.x and 5.x gems * The Hiera Gem needs to be set on Puppet 4.7.1 as it has incompatibilites with later hiera gem versions (4.4.2) * Brings the Travis CI config file into a similar format as that used by the PDK to make migration easier later. * The Travis file needs to remain unmanaged until it supports setting the bundler_args setting
Merge pull request #276 from glennsarti/fix-broke-stuff
(MODULES-6688) Use travis for CI testing, instead of Jenkins
Merge pull request #274 from glennsarti/pe-23563-stop-services
(PE-23563) Stop MCO and Puppet prior to MSI install
(PA-1887) Fix osfamily::darwin OSX version regex
The previous regex used a character class instead of a union to match the major Mac OSX product version, which would match values such as "10.14", "10.15". This meant that the puppet_agent module would think these are supported platforms, and proceed further with the installation (failing at a different point, which would produce a harder-to-read error message). This commit fixes things so that non-supported Mac OSX platforms correctly fail in the osfamily::darwin class with a readable error message.
Merge pull request #278 from ekinanp/fix-osx-regex
(PA-1887) Fix osfamily::darwin OSX version regex
(MODULES-6708) Install CA Certs for module downloading
Previously the CA Certs were not required to be explicitly installed however the forge appears to be using newer certificates now which are not in the default OpenSSL pack on Windows nodes. This commit uses the install_ca_certs helper to install the CA Certs prior to downloading modules from the forge.
(MODULES-6708) Use puppetlabs-inifile 2.1.0 or less
Previously the puppetlabs-inifile module was still compatible with Puppet 3.8, however as of 2.1.1 the syntax changes are not able to be used with older ruby (1.8) which is common with older Puppet versions. This commit pins the inifile module version and updates the test fixtures.
(MODULES-6717) Pin module versions in acceptance test fixtures
Previously the acceptance tests would use the latest versions of dependant modules, however due to supporting Puppet 3.8 this is no longer possible. This commit pins the acceptance module versions to that specified in the metadata json file.
(MODULES-6826) Pin rspec-puppet to 2.6.9
Version 2.6.10 introduced an error that was failing on Puppet gem 4.0.0. This commit pins rspec-puppet to 2.6.9. This should be removed once the error is fixed.
Merge pull request #281 from glennsarti/last-3.8-release
(MODULES-6717) Configure 1.x branch for last 3.8 compatible release
(MODULES-6832) Prepare for v1.6.0 release
This commit prepares the module for a v1.6.0 release This is the last release that will be compatible with Puppet 3.x.
Merge pull request #282 from glennsarti/MODULES-6832-release-1.6.0
(MODULES-6832) Prepare for v1.6.0 release