(PA-5266) Change checksum algorithm to default
Prior to this commit, the puppet_agent::prepare::package class used the sha256lite algorithm in the file resource for local installation packages. In certain circumstances (e.g. when a download is interrupted), this checksum, which only checks the first N bytes, does not provide sufficient information to determine if the file is actually there. This commit removes the checksum attribute altogether, which causes the file resource to use its default algorithm, sha256. This algorithm should handle circumstances like those outlined above.
Merge pull request #670 from mhashizume/PA-5266/main/prepare-digest
(PA-5266) Change checksum algorithm to SHA256
Adding Trusted Contributors to the CODEOWNERS will allow them to meet our branch protection rules and merge pull requests. If you would rather keep that privilege for your own team, then you can decline this PR.
(maint) Update optional parameters
As part of 404df9d all parameters in this module were assigned a data type. However, some required parameters were mistakenly classed as Optional and vice-versa. Puppet's documentation states "If a class parameter lacks a default value, the parameter is considered required."[1] This commit updates all parameters with default values to Optional (and whatever other relevant data type) and all parameters without default value as required. The REFERENCE.md has been updated to reflect these changes. Additionally, this commit updates all Optional parameters be set as undef, as suggested by the optional_default puppet-lint check. [1] https://www.puppet.com/docs/puppet/7/lang_classes#class-parameters-and-variables
Merge pull request #671 from mhashizume/maint/main/optional-parameters
(maint) Update optional parameters
Merge pull request #656 from puppetlabs/trusted-contributors
(maint) Update CODEOWNERS
(maint) Fix skip_if_unavailable allowed datatypes
In PR #663 an overly strict datatype was set for the skip_if_unavailable parameter. The yumrepo type supports a variety of string values and boolean values.
Merge pull request #672 from seanmil/expand_skip_if_unavailable_type
Match allowed datatypes to yumrepo skip_if_unavailable support
(PA-5820) Correct parameter types
Previously, 74e022d erroneously typed the $package_version and $install_options parameters as Optional. This commit updates those parameters to be required, and gives a more specific type to $install_options.
Merge pull request #673 from mhashizume/PA-5820/main/data-type-correc…
…tions (PA-5820) Correct parameter types
(PA-5792) Update Checkout GitHub Action
The Checkout GitHub Action v3 uses Node 16, which hit end-of-life on September 11, 2023. This commit updates all instances of the Checkout Action from v3 to v4.
Merge pull request #674 from mhashizume/PA-5792/main/checkout-action
(PA-5792) Update Checkout GitHub Action
Merge pull request #675 from skyamgarp/PA-5013
(PA-5013) Add Red Hat 9 (ARM64) to the puppet_agent module task
Merge pull request #676 from imaqsood/PA-5065
(PA-5065) Add Ubuntu 22.04 (ARM64) to the puppet_agent module
(PA-5826) Only read Windows VERSION file during puppet apply
Previously, puppetserver attempted to load the wrong VERSION file when managing
`package_version => auto` and compiling catalogs for Windows nodes as can be
seen by the new test:
Evaluation Error: Error while evaluating a Function Call, Could not find any files from C:\Program Files\Puppet Labs\Puppet\VERSION (file: path/to/init.pp, line: 170, column: 42)
This adds a `puppet_runmode` fact. When running as puppet agent, the run mode will
be `agent`. When running as puppet apply, it will be `user`. If it's the latter
and we're a Windows host, then look for the VERSION file locally.
Since the default class parameter is no longer dependent on the agent
fact, I regenerated the reference using rake strings:generate:referenceMerge pull request #677 from joshcooper/windows_auto_5826
(PA-5826) Only read Windows VERSION file during puppet apply
.project files were once used for the long-defunct Geppetto. This commit removes an old .project file in the root of this project.
Merge pull request #678 from mhashizume/maint/main/geppetto-removal
(maint) Remove .project file
Merge pull request #680 from puppetlabs/release-prep
Release prep v4.16.0