Fix psql_metrics error checking #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharpie
force-pushed
the
fix_psql_metrics
branch
2 times, most recently
from
588b805
to
55e705b
Compare
This commit updates the psql_metrics collection script to fix an issue with error checking. Previously, the script sanitized the hostname that output data was stored under by replacing "." characters with "-" characters. But, the error checking routine attempted to look up data using the un-sanitized hostname. This caused error checking to always register a failure even when data collection was successful, which resulted in email spam from cron. Ref. puppetlabs#71 Fixes puppetlabs#77
Sharpie
force-pushed
the
fix_psql_metrics
branch
from
55e705b
to
9cea5f5
Compare
jarretlavallee
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the psql_metrics collection script to fix an
issue with error checking. Previously, the script sanitized the
hostname that output data was stored under by replacing "." characters
with "-" characters. But, the error checking routine attempted to
look up data using the un-sanitized hostname. This caused error
checking to always register a failure even when data collection
was successful, which resulted in email spam from cron.