Use the /v2 metrics endpoint instead of /metrics #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base url /metrics has long been a deprecated URL and creates noise when tested like this. Not to mention in current puppetdb master we are removing /v1 support so this test starts to break. By making it /v2, we still afford support for most of our 1.x users, and since /v2 will be around for quite some time this seems like a suitable temporary step. In the future a generic URL should really be provided by PuppetDB as something that is more permanent and generic. Signed-off-by: Ken Barber <ken@bob.sh>
Signed-off-by: Ken Barber <ken@bob.sh>
senior
added a commit
that referenced
this pull request
Feb 11, 2014
Use the /v2 metrics endpoint instead of /metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base url /metrics has long been a deprecated URL and creates noise when
tested like this. Not to mention in current puppetdb master we are removing
/v1 support so this test starts to break.
By making it /v2, we still afford support for most of our 1.x users, and
since /v2 will be around for quite some time this seems like a suitable
temporary step.
In the future a generic URL should really be provided by PuppetDB as something
that is more permanent and generic.
Signed-off-by: Ken Barber ken@bob.sh