Fix is_pe declaration so it works without is_pe

[kbarber]

Signed-off-by: Ken Barber ken@bob.sh

[juanbrein]

Please take a look at #124 first.

[wleese]

Has a different fix been committed anywhere?

[kbarber]

@wleese. No, but at the same time the is_pe bug has never actually published either. If you're working against master, then you do so at your own risk sorry :-). Pin to a released tag or use the forge version if you want stability.

[wleese]

Good point, thanks.

[kbarber]

@senior can you review this one when you get a chance? Thanks :-).

[raphink]

As stated in #122, I think str2bool($::is_pe) would be more elegant than testing against the 'true' string.

[kbarber]

@raphink I just don't like the undef behaviour of str2bool:

# puppet apply -e 'str2bool($::foo)'
Error: Function 'str2bool' must be the value of a statement at line 1 on node puppetdb1.vm

[raphink]

Interesting.

[kbarber]

@raphink sorry just woke up, I'm totally wrong wrong wrong :-).

[kbarber]

@raphink

# puppet apply -e 'notice(str2bool($::foo))'
Notice: Scope(Class[main]): false

Its fine ... this is such a trivially annoying issue, I'm not sure how much I care. Throw a patch if you like :-).