Add strict_variables support when puppetdb is not on puppetmaster

[mcanevet]

When using the new strict_variables feature of puppet 3.5, including puppetdb::master::config on the puppetmaster fails with Undefined variable "puppetdb::disable_ssl" because Class[puppetdb] is not declared and so puppetdb::disable_ssl is not defined if puppetdb and puppetmaster are not on the same machine.

[kbarber]

@mcanevet can you give a greater description of what you are trying to solve here?

[mcanevet]

@kbarber sure. Is it clear enough with this description ?

[kbarber]

@mcanevet maybe we should just change our rspec-puppet/travis setup to always have this 'strict_variables' option on for 3.5.0? That way we won't regress in the future.

[mcanevet]

@kbarber and now everything fails :-)

[mcanevet]

@kbarber last failing unit test is due to bugs in puppetlabs-postgresql. I'm fixing it here: puppetlabs/puppetlabs-postgresql#402

[kbarber]

@mcanevet we specialize in opening cans of worms it seems :-).

[raphink]

[mcanevet]

@kbarber I added env: PUPPET_GEM_VERSION="~> 3.5.0.rc3" STRICT_VARIABLES="yes"as allowed failure because the issue comes from puppetlabs-postgresql.
Can you merge this ?

[kbarber]

@mcanevet I'd rather not allow this to go in without fixing the upstream confirmed, otherwise no one will find the time to fix it correctly :-). Also - I'd rather this be a mandatory pass/fail if we can.

I've had @apenney merge in your change to postgresql, but I'm still seeing an error related to postgres when I re-run your tests. Can you take another look please? https://travis-ci.org/puppetlabs/puppetlabs-puppetdb/jobs/22608476

[kbarber]

@mcanevet actually looks like its turtles all the way down. Its throwing an error for 'concat' now, not postgresql.

[mcanevet]

@kbarber fixed

[kbarber]

@mcanevet excellent. I think the last thing is to remove the allow_failures part. I'm more of the preference to fail hard now we've got it right.

[mcanevet]

@kbarber done

[kbarber]

@mcanevet thanks mate, 2 modules down, god knows how many to go. You've been great on this one, thanks very very much.