implement max_threads option for jetty #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, apparently #128 already implemented this wish-feature, but in my solution the option will not be set unless it is actively set. pull/128 will always explicetly add max_threads even if not needed. |
| @@ -293,6 +293,11 @@ Java VM options used for overriding default Java VM options specified in PuppetD | |||
|
|
|||
| Example: to set `-Xmx512m -Xms256m` options use `{ '-Xmx' => '512m', '-Xms' => '256m' }` | |||
|
|
|||
| ####`max_threads` | |||
|
|
|||
| Jetty option to explicetly set max-thread. The default is undef, so the jetty default is used (might be `120`). | |||
There was a problem hiding this comment.
Probably not worth providing an assumption here (ie. 120) as its misleading from the start and the default may change anyway. I'd just say it falls back to the PuppetDB default.
|
Okay, I removed the assumption. |
kbarber
added a commit
that referenced
this pull request
Jul 1, 2014
implement max_threads option for jetty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a server with 256 GB RAM, the default jetty option for max_threads will not be enough.
The puppetdb.log will say:
java.lang.IllegalStateException: Insufficient max threads in ThreadPool: max=100 < needed=121So we need the max_threads option to set the threads in the jetty.ini.