Fix detection of a PE-based PuppetDB #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new spec test providing some initial coverage of puppetdb::server demontrating the failure to correctly detect a PE environment.
defined('$::is_pe') will never evaluate to true, even if
the is_pe fact is defined. defined('$is_pe') will return the
correct results.
|
@seanmil sweet, thanks. |
kbarber
added a commit
that referenced
this pull request
Oct 4, 2014
Fix detection of a PE-based PuppetDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the detection of whether or not the environment is a PE-based PuppetDB environment when checking on the is_pe fact.
These commits add an initial spec test to show both the regular and PE-style behaviors that are expected and then a second commit which corrects the behavior.
Thanks!