Make database validation optional #157
Conversation
|
It seems the Travis CI failures are only on Ruby 1.8.7. and not related to my changes. |
| } | ||
|
|
||
| $ini_setting_require = str2bool($database_validate) ? { | ||
| false => undef, | ||
| default => Class['puppetdb::server::validate_db'], |
There was a problem hiding this comment.
You could avoid this entirely by setting the class's (puppetdb::server::validate_db) before param to Ini_setting <| |> ; collecting on all Ini_setting's :)
There was a problem hiding this comment.
Probably not worth doing it this time around, but worth thinking about later. If we ever get around to implementing a defined resource to wrap these ini settings or something, probably better to do it using that resource instead of inifile, since inifile could bleed into other modules and create more edges than necessary in the graph. Extraneous edges == bad sometimes, because it makes for a larger catalog.
|
@robinbowes ping :-). |
|
@robinbowes see previous comments, also I think this needs a rebase now. |
robinbowes
force-pushed
the
make_validate_db_optional
branch
from
77ed676
to
69a096e
Compare
|
Rebased. |
|
@robinbowes this looks okay now, one thing we forgot to ask for before was the documentation changes for this new parameter in the README.md, can you add this? Sorry, shouldn't have noticed this earlier. Also - you might want to squash your commits into 1 while you're at it. |
robinbowes
force-pushed
the
make_validate_db_optional
branch
from
69a096e
to
1a5a4ef
Compare
|
How's that? |
|
@robinbowes perfect, thanks mate :-). |
Make database validation optional
We don't want to validate the DB connection when building puppetdb nodes as we're building AMIs on AWS that won't necessarily have access to the RDS instance they will eventually use when instantiated.
This PR adds a couple of flags to make the db validation optional, one for database, one for read_database.
R.