Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to manage postgres repo #162

Merged
merged 3 commits into from
Feb 3, 2015

Conversation

bastelfreak
Copy link
Collaborator

the module triggers puppetlabs-postgresql which is able to handle yum/apt repos from the postgres devs. Usefull in cases that your operating system doesn't provide the newest release. this feature is disabled by default

just migrated my puppetdb postgres 9.2 from centos7 to 9.4, working fine with two puppet runs.

the module triggers puppetlabs-postgresql which is able to handle yum/apt repos from the postgres devs. Usefull in cases that your operating system doesn't provide the newest release. this feature is disabled by default

fix typo
$database_password = 'puppetdb'
$database_ssl = false
$database_validate = true
$postgres_version = '9.4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbarber should this be a 9.3 default for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the default being the latest, I can see this being another annoying place to constantly update however :-). Kind of wish there was a way to just say 'give me the latest always' instead. But hohum, yes 9.4 is fine.

@kbarber
Copy link
Contributor

kbarber commented Jan 27, 2015

@bastelfreak this will need updates to the README.md to cover the new parameters, can you please add these? We'll also need to functionally test this as well.

@bastelfreak
Copy link
Collaborator Author

@kbarber updated the README.md. Can you offer any help or tutorials for the needed functionally test?

@kbarber
Copy link
Contributor

kbarber commented Jan 28, 2015

Don't worry @bastelfreak the functional test is on us to do today. We'll move this back into for review, thanks.

@bastelfreak
Copy link
Collaborator Author

ah okay. let me know if you need additional changes or if I should do a rebase

kbarber added a commit that referenced this pull request Feb 3, 2015
add ability to manage postgres repo
@kbarber kbarber merged commit 04f81ee into puppetlabs:master Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants