Enable the module to manage entries in $confdir/config.ini #176
Conversation
|
this looks good to me |
| @@ -55,6 +55,9 @@ | |||
| $manage_firewall = $puppetdb::params::manage_firewall, | |||
| $java_args = $puppetdb::params::java_args, | |||
| $max_threads = $puppetdb::params::max_threads, | |||
| $command_threads = $puppetdb::params::command_threads, | |||
There was a problem hiding this comment.
Since these all default to undef, you could probably just explicitly set them to undef here.
|
👍 aside from the |
|
I added a file resource to the server/config_ini.pp file to take care that it exists before trying to manipulate it. On OpenBSD, its owned by root:wheel, however, that is usually the user puppet runs on. I kept the parameter definitions to undef in param.pp, because they are passed in in init.pp, and server.pp. If everyone ever wants to change them, it can be done centrally in init.pp, so I hope that is fine. Unfortunately, the travis tests currently fail, because of updates/changes in the "concat" modules git repo. I didn't wanted to mess with the specs, therefore I haven't done anything in that regard ;) |
|
Looks like we pull in another dependency for concat now, it wraps a native tool from electrical now: https://github.com/puppetlabs/puppetlabs-postgresql/pull/612/files. I guess we can either pin, or bump. |
|
Trying to fix the testing issues here: #177 |
command-processing section. Added new class server/config_ini.pp to manage contents of the config.ini. Three new parameters added: * command_threads * store_usage * temp_usage All three default to 'undef'. This makes sure (potential) custom settings done to that file with regard to above three variables are 'absent', and let PuppetDB built-in defaults take care. Documentation to the README.md added, as well as unit tests. My use-case was, that I have on some nodes a too small /var partition, so I had to lower the values of store-usage and temp-usage in the config.ini manually.
|
rebased, and specs seem to be all green again. |
Enable the module to manage entries in $confdir/config.ini
with regard to the command-processing section.
Added new class server/config_ini.pp to manage contents of the config.ini.
Three new parameters added:
All three default to 'undef'. This makes sure (potential) custom settings
done to that file with regard to above three variables are 'absent',
and let PuppetDB built-in defaults take care.
Documentation to the README.md added, as well as unit tests.
My use-case was, that I have on some nodes a too small /var partition,
so I had to lower the values of store-usage and temp-usage in the config.ini
manually.