Make puppetdb startup timeout configurable #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments, puppetdb can take longer than 10 seconds to start up. Prior to this commit, that value was hard coded and the module would sometimes fail when it wouldn't have failed with a slightly larger timeout. This commit makes the timeout configurable, and also increases the default value to 15 seconds.
cprice404
added a commit
that referenced
this pull request
Oct 17, 2012
…-puppetdb-startup-timeout Make puppetdb startup timeout configurable
| $puppetdb_version = $puppetdb::params::puppetdb_version, | ||
| $terminus_package = $puppetdb::params::terminus_package, | ||
| $puppet_service_name = $puppetdb::params::puppet_service_name, | ||
| $puppetdb_startup_timeout = $puppetdb::params::puppetdb_startup_timeout, | ||
| $restart_puppet = true, |
There was a problem hiding this comment.
This should also be aligned. Also, if we want to be Puppet 2.6 compatible then the last parameter should not have a trailing ,
There was a problem hiding this comment.
I don't think that PuppetDB is compatible with Puppet 2.6, but it wouldn't hurt to remove this anyway. Thanks for the note!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments, puppetdb can take longer than 10 seconds
to start up. Prior to this commit, that value was hard coded
and the module would sometimes fail when it wouldn't have failed
with a slightly larger timeout. This commit makes the timeout
configurable, and also increases the default value to 15 seconds.