(PDB-1657) Manage Postgres repos by default #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajroetker
force-pushed
the
ticket/pdb-1657/master/manage_pg_repos_by_default
branch
from
8f73617
to
d67159d
Compare
| @@ -144,6 +144,7 @@ Upgrading | |||
| Significant parameter changes are listed below: | |||
|
|
|||
| * The PuppetDB module now supports PuppetDB 3.0.0 by default | |||
| * The PuppetDB module now manages Postgres repos by default, to turn this behavior off, set `manage_package_repo` to false. | |||
There was a problem hiding this comment.
first comma should be a period with a new sentence
|
a couple tiny comments above -- looks good to me otherwise |
This commit moves to managing the Postgres repos by default. The reason for this is so that the `puppetdb` class will "just work" by default on most systems, because PostgreSQL 9.4 is not installed on 6/7 of the distros we support we need to manage the repos so we can install the latest version.
ajroetker
force-pushed
the
ticket/pdb-1657/master/manage_pg_repos_by_default
branch
from
d67159d
to
8eb9f67
Compare
wkalt
added a commit
that referenced
this pull request
Jun 25, 2015
…pg_repos_by_default (PDB-1657) Manage Postgres repos by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves to managing the Postgres repos by default. The
reason for this is so that the
puppetdbclass will "just work" bydefault on most systems, because PostgreSQL 9.4 is not installed on 6/7
of the distros we support we need to manage the repos so we can install
the latest version.