(PDB-1430) overwritable java_args #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkalt
force-pushed
the
ticket/master/pdb-1430-overwritable-java-args
branch
from
471db5e
to
4a1f324
Compare
this creates a new config setting, merge_default_java_args, that users may set to false to override the default java_args.
|
@kbarber this looks good to me but would you mind taking a look as well? |
|
I learned today that this won't work on versions of puppetdb core that package with ezbake up to and including the latest version, since ezbake itself hardcodes some default java args. This won't affect the 2.x version that motivated this patch, and shouldn't affect 3.x versions in the near future. Shouldn't prevent this being merged imo. |
ajroetker
added a commit
that referenced
this pull request
Sep 28, 2015
…e-java-args (PDB-1430) overwritable java_args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this creates a new config setting, merge_default_java_args, that users may set
to false to override the default java_args.