Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postgresql.pp with postgresql contrib package #225

Merged
merged 2 commits into from
May 10, 2016
Merged

Update postgresql.pp with postgresql contrib package #225

merged 2 commits into from
May 10, 2016

Conversation

PascalBourdier
Copy link
Contributor

postgresql contrib package is needed to avoid warn message about pg_trgm indexes

postgresql contrib package is needed to avoid warn message about pg_trgm indexes
@kbarber kbarber added this to the 5.1.3 (master) milestone Apr 4, 2016
@kbarber
Copy link
Contributor

kbarber commented Apr 20, 2016

I have a PR that fixes the travis failures here: #227

@kbarber
Copy link
Contributor

kbarber commented Apr 20, 2016

@PascalBourdier is this enough to remove the warnings though? Because afaik we don't run the 'CREATE EXTENSION' bit ourselves, and this would be needed.

So perhaps a defined resource can be used to install the pg_trgm extension for the puppetdb db for this to be automated fully:

postgresql::server::extension { "${database_name}-pg_trgm":
  database => $database_name,
  extension => 'pg_trgm',
  require => Class['postgresql::server::contrib'],
}

Or something to this effect?

@kbarber
Copy link
Contributor

kbarber commented Apr 27, 2016

@PascalBourdier have you had some time to consider my comments yet?

@PascalBourdier
Copy link
Contributor Author

Hi,

Sorry I am in a travel but I make your corrections as soon as possible.

Regards

Le mercredi 27 avril 2016, Ken Barber notifications@github.com a écrit :

@PascalBourdier https://github.com/PascalBourdier have you had some
time to consider my comments yet?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#225 (comment)

Pascal
+33 6 63 85 68 18

@kbarber
Copy link
Contributor

kbarber commented May 6, 2016

@PascalBourdier if you have the time, let us know. I think others are asking for this, so perhaps we'll just submit our own PR for this to update yours.

add pg_trgm postgresql extension and contrib package for dependency
@kbarber
Copy link
Contributor

kbarber commented May 10, 2016

@PascalBourdier thanks, tested this and it looks good.

@kbarber kbarber merged commit e5d8c6b into puppetlabs:master May 10, 2016
@PascalBourdier PascalBourdier deleted the postgresql-contrib branch May 10, 2016 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants