Manage the pool size configuration parameters in database.ini #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kpaulisse Thanks for the contribution! I'll test this out. |
| # Get the parameter name for the database connection pool tuning | ||
| if $puppetdb_version in ['latest','present'] or versioncmp($puppetdb_version, '4.0.0') >= 0 { | ||
| $database_max_pool_size_setting_name = 'maximum-pool-size' | ||
| } elsif versioncmp($puppetdb_version, '3.2.0') >= 0 { |
There was a problem hiding this comment.
We could set this all the way to 2.8.0 at least! :)
There was a problem hiding this comment.
I'm absolutely happy to do that - but I have no way of testing anything less than 3.2 for myself.
There was a problem hiding this comment.
No problem I've got you covered there, I've verified this on 2.8.7 so it should be ok for the whole of the 2.8 series (which is as far back as we support anyways).
There was a problem hiding this comment.
Updated code to change 3.2.0 to 2.8.0 for that comparison. Thanks!
|
👍 from me. Will merge when I get another quick sanity check from another PuppetDB team member. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#229 is a PR from a few weeks ago to add pool size configuration parameters to database.ini. I also needed this feature, but I run PuppetDB 3.2 and because of differences in the parameter name, I needed to make some updates. Unfortunately, I didn't receive a response when I submitted these changes to the author of that PR (in nward#1) so I am opening this directly here.
In this implementation, the default is that
partition-conn-max/maximum-pool-sizewill not be put into the configuration files. If specified by appropriately named hiera keys or other lookup method, thenpartition-conn-maxwill be configured for PuppetDB 3.2, andmaximum-pool-sizewill be configured for PuppetDB 4.0 and later.I have tested this on PuppetDB 3.2 and it works. I don't have PuppetDB 4.0 so I can't test the end result there. I've also resolved the merge conflicts between #229 and the current master, to make this merge-able.