New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit dependency db -> extension. #272

Merged

Zak-Kent merged 1 commit into puppetlabs:master from pgassmann:master

Nov 6, 2017

Contributor

pgassmann commented Oct 18, 2017

The dependency to the database is missing. This should be explicitly added. postgresql::server::extension does not add the dependency automatically, because the database is definded below, after the extension, so the defined() check does not work. https://github.com/puppetlabs/puppetlabs-postgresql/blob/34aa0affa233e04a25c3b4d130e6db867bff08bd/manifests/server/extension.pp#L48-L50

    postgresql::server::extension { 'pg_trgm':
      database  => $database_name,
      require   => Postgresql::Server::Db[$database_name],
    }

related to #271


          add explicit dependency db -> extension.

31442e4

Contributor

Zak-Kent commented Nov 6, 2017

Thank you for adding this @pgassmann :) The test errors you saw will be fixed in an upcoming PR.

Zak-Kent merged commit 942465b into puppetlabs:master

smortex added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels