Setup for 7.0.0 release #279
Conversation
austb
force-pushed
the
modules-7359-make-a-release
branch
from
7a451f3
to
bfa6fb6
Compare
Zak-Kent
force-pushed
the
modules-7359-make-a-release
branch
2 times, most recently
from
2926ca8
to
59ce091
Compare
Zak-Kent
force-pushed
the
modules-7359-make-a-release
branch
4 times, most recently
from
75331b1
to
1aa7ae8
Compare
Zak-Kent
force-pushed
the
modules-7359-make-a-release
branch
from
1aa7ae8
to
f2a2c24
Compare
|
Hey people. Can I get a review of #278 before 7.0.0 gets released? |
|
@bastelfreak absolutely, we'll take a look at #278 before we do the 7.0.0 release. We've been trying to get our internal testing stuff up to par which is why this hasn't gone out yet. We still have time to add stuff to this before it goes out. Thanks for the help! |
Zak-Kent
force-pushed
the
modules-7359-make-a-release
branch
6 times, most recently
from
a162ba6
to
d5bcfdc
Compare
|
You might also want to get rid of https://github.com/puppetlabs/puppetlabs-puppetdb/blob/master/manifests/server.pp#L75-L82 ? |
Zak-Kent
force-pushed
the
modules-7359-make-a-release
branch
3 times, most recently
from
6714140
to
d5bcfdc
Compare
Prior to this commit, tests in master were broken due to changes in rspec puppet. The last working version for the previous code to successfully test on was rspec-puppet 2.6.11. This commit updates the spec tests to work with 2.6.12 and 2.6.13
Zak-Kent
force-pushed
the
modules-7359-make-a-release
branch
4 times, most recently
from
6e91059
to
183c7b5
Compare
Zak-Kent
force-pushed
the
modules-7359-make-a-release
branch
from
183c7b5
to
9fedb0d
Compare
spec/spec_helper_acceptance.rb
Outdated
|
|
||
| def build_url(platform) | ||
| use_pup4 = use_puppet4 | ||
| if use_pup4 |
There was a problem hiding this comment.
Maybe just use if use_puppet4? I don't think we need it in a variable
spec/spec_helper_acceptance.rb
Outdated
| on host, 'yum install -y puppetserver' | ||
| elsif host['platform'] =~ %r{(ubuntu|debian)} | ||
| unless host.check_for_package 'curl' | ||
| on host, 'apt-get install -y curl' | ||
| end | ||
| # For openjdk8 | ||
| use_pup4 = use_puppet4 | ||
| if host['platform'].version == '8' && !use_pup4 |
There was a problem hiding this comment.
Same here, unless its possible to change in between this usage and the one below, but I don't think that will happen?
spec/spec_helper_acceptance.rb
Outdated
| @@ -2,26 +2,66 @@ | |||
| require 'beaker/puppet_install_helper' | |||
| require 'beaker/module_install_helper' | |||
|
|
|||
| def use_puppet4 | |||
| (ENV['PUPPET_INSTALL_VERSION'] =~ %r{2016}) ? true : false | |||
There was a problem hiding this comment.
We should ensure that the 2016 is at the start of the string %r{^2016}. Though we have some problems if we ever get to 2016 in a y or z release...
Everything that isn't nil or false will be true in ruby, so ENV['PUPPET_INSTALL_VERSION'] =~ %r{^2016} is sufficient for this to work.
Zak-Kent
force-pushed
the
modules-7359-make-a-release
branch
3 times, most recently
from
51043a4
to
9283581
Compare
Zak-Kent
force-pushed
the
modules-7359-make-a-release
branch
from
9283581
to
da9cc18
Compare
|
👍 |
This release adds pdk compatibility and replaces validate_* methods with data types.