Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow inifile 3.x and postgresql 7.x #290

Merged
merged 2 commits into from
May 16, 2019
Merged

Allow inifile 3.x and postgresql 7.x #290

merged 2 commits into from
May 16, 2019

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented May 16, 2019

No description provided.

@ekohl ekohl changed the title Allow inifile 3.x Allow inifile 3.x and postgresql 7.x May 16, 2019
binford2k
binford2k approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@binford2k binford2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like the test failure is unrelated to this PR. 👍

@binford2k binford2k requested review from austb and Zak-Kent May 16, 2019 20:29
@austb
Copy link
Contributor

austb commented May 16, 2019

The travis failure looks like it just needs a bump in the ruby version

@austb austb merged commit f9c3be8 into puppetlabs:master May 16, 2019
@ekohl ekohl deleted the allow-inifile-3 branch May 16, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austb austb austb approved these changes

@binford2k binford2k binford2k approved these changes

@Zak-Kent Zak-Kent Awaiting requested review from Zak-Kent

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekohl @austb @binford2k @smortex