Create enable_storeconfigs option for puppet::master::config #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gcoxmoz! Thanks for the contribution! Can you elaborate on your use case a bit? Generally I just want to make sure there's a reasonable time to be managing both PuppetDB and the Puppet Master's |
|
Sure, the use case here was to be able to temporarily sever contact between puppetserver and puppetdb during a prolonged outage of puppetdb. Dropping 'puppetdb' out the 'reports' line was easy, but taking out 'storeconfigs' meant having to touch the puppet.conf on the server by hand instead of being able to turn it off in hiera. |
austb
requested changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(MODULES-9905) Create enable_storeconfigs option for puppet::master::config
This creates a flag to allow the removal of 'storeconfigs' and 'storeconfigs_backend' directives from puppet.conf when those directives are managed by the module.
No tests are included here because there was no unit test to begin with(?!).