(PDB-2578) Allow the database password to be unmanaged #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemccurdy
force-pushed
the
unmanaged_password
branch
from
b50b05c
to
1a7a9ac
Compare
natemccurdy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, it was impossible to not manage the database and read-database passwords. An attempt to allow
undefas the password was made in #78 but that failed to solve the problem as a default value ofpuppetdbis pulled from params.pp.This PR adds two new parameters to the
puppetdbandpuppetdb::serverclasses:manage_db_passwordmanage_read_db_passwordBoth default to
trueto retain backwards compatibility.Setting these new parameters to
falsewill cause theini_settingresource that manages the password entry to not be enforced.This is useful for folks that don't want to put plaintext passwords in their code or who want to manage that password value some other way besides with Puppet.
Fixes: https://tickets.puppetlabs.com/browse/PDB-2578