Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide passwords from output #320

Merged
merged 2 commits into from May 7, 2024

Conversation

gfa
Copy link
Contributor

@gfa gfa commented Dec 22, 2020

Based on @camilo-schoeningh-sociomantic 's work on PR #284

@gfa gfa requested a review from a team as a code owner December 22, 2020 16:20
@gfa gfa force-pushed the gfa_mark_passwords_as_sensitive branch 2 times, most recently from dbe3cae to 21e7eab Compare December 22, 2020 16:50
@gfa gfa marked this pull request as draft December 22, 2020 21:20
@gfa gfa force-pushed the gfa_mark_passwords_as_sensitive branch 2 times, most recently from dc8a5f4 to f1d2187 Compare December 29, 2020 13:50
@gfa gfa marked this pull request as ready for review December 29, 2020 13:59
@gfa gfa marked this pull request as draft December 29, 2020 13:59
@gfa gfa force-pushed the gfa_mark_passwords_as_sensitive branch from f1d2187 to 8a7f792 Compare December 29, 2020 14:03
@gfa gfa marked this pull request as ready for review December 29, 2020 14:03
@gfa gfa changed the title Use Sensitive data type to prevent leaking credentials Hide passwords from output Dec 30, 2020
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfa gfa requested a review from bastelfreak as a code owner May 5, 2024 15:58
@h0tw1r3 h0tw1r3 force-pushed the gfa_mark_passwords_as_sensitive branch from 14b1ee1 to 5960920 Compare May 5, 2024 16:05
@smortex smortex force-pushed the gfa_mark_passwords_as_sensitive branch from 4f9c5c6 to 9592788 Compare May 6, 2024 21:41
@bastelfreak bastelfreak merged commit f9b7f7f into puppetlabs:main May 7, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants