Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDB-5052) Install PostgreSQL 11 for PDB > 7.0.0 #333

Merged
merged 1 commit into from
Jul 20, 2021
Merged

(PDB-5052) Install PostgreSQL 11 for PDB > 7.0.0 #333

merged 1 commit into from
Jul 20, 2021

Conversation

oanatmaria
Copy link

No description provided.

@oanatmaria oanatmaria requested a review from a team as a code owner July 18, 2021 08:18
@puppet-community-rangefinder
Copy link

puppetdb::params is a class

that may have no external impact to Forge modules.

This module is declared in 33 of 577 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

austb
austb reviewed Jul 19, 2021
View reviewed changes
manifests/params.pp Outdated
$postgres_version = '9.6'

if $puppetdb_version in ['latest','present'] or versioncmp($puppetdb_version, '7.0.0') >= 0 {
$postgres_version = '11.12'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Between postgres 9.6 and postgres 10 they changed their versioning semantics. Before the third number indicated a minor release, whereas now incrementing the second number is a minor release. I think we can just use 11 here to ensure that we pick up the latest minor releases of postgres as they are release.

More details of their versioning policy can be found here https://www.postgresql.org/support/versioning/

@austb austb merged commit 3ea57a5 into puppetlabs:master Jul 20, 2021
kenyon added a commit to kenyon/puppetlabs-puppetdb that referenced this pull request Dec 20, 2021
@kenyon
README: correct postgres_version docs
efc8ef2 
Missed this doc update with puppetlabs#333.
@kenyon kenyon mentioned this pull request Dec 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austb austb austb approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oanatmaria @austb @smortex