Restrict configuration file permissions #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PuppetDB runs as the puppetdb user. This user must have read access to the various configuration files but does not need write access to them. This ensure the service configuration cannot be unexpectedly changed by PuppetDB itself if some vulnerability allow random code execution, limiting the possibilities of exploitation and pivoting if such a vulnerability is found.
puppetdb::server is a classthat may have no external impact to Forge modules. puppetdb::server::database is a classthat may have no external impact to Forge modules. puppetdb::server::global is a classthat may have no external impact to Forge modules. puppetdb::server::jetty is a classthat may have no external impact to Forge modules. puppetdb::server::puppetdb is a classthat may have no external impact to Forge modules. puppetdb::server::read_database is a classthat may have no external impact to Forge modules. This module is declared in 33 of 578 indexed public
|
|
|
h0tw1r3
force-pushed
the
security-file-permissions
branch
from
810aa3c
to
36a8cd8
Compare
bastelfreak
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PuppetDB runs as the puppetdb user. This user must have read access to the various configuration files but does not need write access to them.
This ensure the service configuration cannot be unexpectedly changed by PuppetDB itself if some vulnerability allow random code execution, limiting the possibilities of exploitation and pivoting if such a vulnerability is found.
This is a companion PR to #342: the FreeBSD port insists on secure file permissions and will enforce them when the service start. On next Puppet run, the module will consider it configuration drift and revert the previous less paranoid configuration and reload the service which will harden the files mode immediatly. Rather than optionaly ignoning the files mode, it makes more sense to use an hardened configuration by default.