(PDB-5611) Update legacy facts to structured form

[austb]

No description provided.

[puppet-community-rangefinder]

puppetdb::master::config is a class

Breaking changes to this file WILL impact these 8 modules (exact match):

• cnacorrea-puppet
• aursu-puppet
• ploperations-puppet
• stephenrjohnson-puppet
• abstractit-puppet
• puppetfinland-puppetmaster
• objectiflibre-puppet
• simp-simp

Breaking changes to this file MAY impact these 3 modules (near match):

• devopera-dopuppetmaster
• example42-psick
• theforeman-puppet

This module is declared in 33 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[jpartlow]

We should probably clean up the facts in the specs as well. Since the specs aren't failing, maybe just deleting the legacy facts? Though I suppose if there are specs that pretend to care about osfamily or fqdn, they might need some prodding.

[austb]

The tests need some work to fix them, we are going to ticket that work and prioritize it via the normal process.