Support for remote puppetdb

[fhrbek]

This PR contains changes that were required to handle connection validation in a more flexible way. The new solution also allows (on demand, not by default) to store configuration settings even when puppetdb is not reachable.

[kbarber]

Can you not increment this? A release increment is decided at release time, its not tied to a particular patch. The next release may be 1.2.0 for example.

[fhrbek]

So, does it mean that 1.2.0 a good target version for me now?

[kbarber]

Just leave it as it was '1.1.5'. The future version should be determined in a release patch not in a particular feature patch like this one.

[fhrbek]

Thanks for your comments, I've been working on fixing the issues.

[kbarber]

@fhrbek cheers - added some more comments to your comments :-).

[puppetcla]

CLA Signed by fhrbek on 2013-01-07 21:00:00 -0800

[fhrbek]

I added an rpec test (is it what you meant?) and I also removed the option (that I had introduced) of reading the puppetdb.conf file which is not needed any more after changing the pe_puppetdb module.

It would be great if we could finally merge this PR and #37.

[kbarber]

@fhrbek. This will need to be rebased as well

[fhrbek]

I've rebased. We've both added spec tests. They don't seem to be in conflict but most of yours fail on my machine, for example

1) puppetdb on a supported platform when using default values for puppetdb class 
     Failure/Error: it { should contain_class('puppetdb') }
     Puppet::Error:
       Could not find class puppetdb for filiphrbeknb.cloudsmith on node filiphrbeknb.cloudsmith
     # ./spec/unit/classes/init_spec.rb:16:in `block (4 levels) in <top (required)>'

Am I doing anything wrong?

[kbarber]

@fhrbek are you running 'rake spec' to run the tests?