allows for 0 _ttl's without time signifier and enables tests #50
Conversation
| } | ||
| end | ||
|
|
||
| ttl_args.each do |ttl_arg| |
There was a problem hiding this comment.
This doesn't really test what you want to test, I'm removing it for now.
There was a problem hiding this comment.
Lines 4-16 should be testing that if you just 'include puppetdb' and use all the defaults, that it should contain the puppetdb class, ie: not fail.
Is that the code to which you are referring?
There was a problem hiding this comment.
Now - I mean the block referenced by line 18.
There was a problem hiding this comment.
Ah yes, that part need the :params hash set to use '0' for the ttl_args
The next part on line 23 should have the :params hash to set something like 1S (capital) which should still work since the code uses downcase()
There was a problem hiding this comment.
Yep - you'll need a new PR for that though.
There was a problem hiding this comment.
Thanks for the insight and help.
|
I merged this in manually with some cleanup, I removed one of the tests because it doesn't do anything - take a look at my comment. Other than that, thanks @ghoneycutt. |
This commit allows you to specify '0' for a _ttl param without having to specify the time signifier. It then validates the _ttl params within the manifest.
Also adds support for spec testing and tests these cases.