Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate DB instance and DB user creation #61

Merged
merged 1 commit into from
May 22, 2013

Conversation

dalen
Copy link

@dalen dalen commented May 6, 2013

Useful to allow more complex setup of the DB server itself while reusing the DB instance creation code.

@kbarber
Copy link
Contributor

kbarber commented May 7, 2013

@dalen whats the point here, so you can setup the database somewhere else, but still use this new postgresql_db class to create the database/username etc.?

# Class: puppetdb::database::postgresql_db
#
# This class manages a postgresql database instance suitable for use
# with puppetdb. It uses the `inkling/postgresql` puppet module for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses the inkling/postgresql puppet module for

No it doesn't any more :-).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, well. should probably do a commit changing that everywhere.

But it points to this issue: https://projects.puppetlabs.com/issues/18731

@dalen
Copy link
Author

dalen commented May 7, 2013

yes, that's the point. As the puppetdb::database::postgresql class doesn't offer enough flexibility.

@kbarber-jenkins-bot
Copy link

Can one of the admins verify this patch?

@kbarber
Copy link
Contributor

kbarber commented May 14, 2013

ok to test

@kbarber-jenkins-bot
Copy link

Merged build triggered. (Status: PENDING, Details: null)

@kbarber-jenkins-bot
Copy link

Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/46/)

@kbarber-jenkins-bot
Copy link

Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/46/)

kbarber added a commit that referenced this pull request May 22, 2013
Separate DB instance and DB user creation
@kbarber kbarber merged commit a56e28a into puppetlabs:master May 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants