-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate DB instance and DB user creation #61
Conversation
|
@dalen whats the point here, so you can setup the database somewhere else, but still use this new postgresql_db class to create the database/username etc.? |
| # Class: puppetdb::database::postgresql_db | ||
| # | ||
| # This class manages a postgresql database instance suitable for use | ||
| # with puppetdb. It uses the `inkling/postgresql` puppet module for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses the
inkling/postgresqlpuppet module for
No it doesn't any more :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, well. should probably do a commit changing that everywhere.
But it points to this issue: https://projects.puppetlabs.com/issues/18731
|
yes, that's the point. As the puppetdb::database::postgresql class doesn't offer enough flexibility. |
|
Can one of the admins verify this patch? |
|
ok to test |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/46/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/46/) |
Separate DB instance and DB user creation
Useful to allow more complex setup of the DB server itself while reusing the DB instance creation code.