Use fqdn for ssl listen address instead of clientcert #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris Barker reported that the default value of `$::clientcert` was not the best choice for some things we were using it for in the module; specifically, for the default value of the jetty ssl listen address. He suggested using `$::fqdn` instead. This commit makes that change; rspec-system tests pass, but I'm not 100% sure that there aren't edge cases that would be affected by this.
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/50/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/50/) |
kbarber
added a commit
that referenced
this pull request
May 22, 2013
…-of-clientcert Use fqdn for ssl listen address instead of clientcert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chris Barker reported that the default value of
$::clientcertwas not the best choice for some things we were using it for
in the module; specifically, for the default value of
the jetty ssl listen address. He suggested using
$::fqdninstead.This commit makes that change; rspec-system tests pass, but I'm
not 100% sure that there aren't edge cases that would be
affected by this.