(GH-73) Switch to puppetlabs/inifile from cprice/inifile #74
Conversation
cprice/inifile is deprecated, this patch changes the module to use inifile's new home puppetlabs/inifile. Signed-off-by: Ken Barber <ken@bob.sh>
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb/152/) |
|
Merged build finished. (Status: FAILURE, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb/152/) |
|
retest this please |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb/154/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb/154/) |
|
I would love to see this happening :) |
|
👍 |
|
Are you planning to push a release to the forge with this change in any time soon? |
…e-deprecated (GH-73) Switch to puppetlabs/inifile from cprice/inifile
|
I have another major change in the pipeline to switch to postgresql 3.0.0 and wanted to hold off for that before release, since this request isn't handled well by the module tool it becomes a major release on its own. No harm in merging this in now though. |
|
Are you saying you won't push another major release before the pg3 changes? |
|
@robinbowes yeah, otherwise it would probably be 2 major releases that way. Is the absence of this change causing a major hassle? |
|
Well, I'm using stephenrjohnson/puppet and it uses puppetlabs/inifile and also puppetdb which uses cprice404/inifile. The cprice404 version is the one that gets installed so all subsequent puppet runs get all the deprecation warnings. I currently work round that by manually removing modues/inifile and installing puppetlabs/inifile. It would be nice to not have to. :) |
|
@robinbowes alright, I'll cut a major release just for this change. |
|
@robinbowes pr #85 covers the release notes. I'll push to get that merged in and released ASAP. |
cprice/inifile is deprecated, this patch changes the module to use inifile's
new home puppetlabs/inifile.
Signed-off-by: Ken Barber ken@bob.sh