Add missing parameters for 1.4.0 release #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds all the missing parameters now defined in the 1.4.0 release. This includes some new database parameters mainly, but also adds gc_interval to the `puppetdb` and `puppetdb::server` classes, as previously this wasn't configurable using this method. To avoid documentation duplication the Puppet headers have been removed in favour of documenting classes from the README.md. Until such times as the forge can turn Puppet docs into HTML automatically, this is just duplicate noise and prone to update slippage. The README.md is more authoritative in this area and is pubicly displayed on the forge project page so it should be used for now. Signed-off-by: Ken Barber <ken@bob.sh>
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb/167/) |
|
This actually passed, but jenkins didn't update this commit for some reason. |
| # | ||
| # Sample Usage: | ||
| # include puppetdb | ||
| # |
There was a problem hiding this comment.
I remember that you had some concerns about the formatting of these docs, but do you think we should be removing them entirely?
There was a problem hiding this comment.
Yep, I do think they should be removed. No one reads it and its duplicated in README.md. Once the forge can process these automatically and generate class and defined resource docs this would be the way to go, but now, its just another place for things to go out of sync :-).
cprice404
added a commit
that referenced
this pull request
Aug 7, 2013
Add missing parameters for 1.4.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds all the missing parameters now defined in the 1.4.0 release.
This includes some new database parameters mainly, but also adds gc_interval
to the
puppetdbandpuppetdb::serverclasses, as previously this wasn'tconfigurable using this method.
To avoid documentation duplication the Puppet headers have been removed in
favour of documenting classes from the README.md. Until such times as the
forge can turn Puppet docs into HTML automatically, this is just duplicate
noise and prone to update slippage. The README.md is more authoritative in
this area and is pubicly displayed on the forge project page so it should be
used for now.
Signed-off-by: Ken Barber ken@bob.sh