Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soft_write_failure to puppetdb.conf #89

Merged
merged 3 commits into from
Oct 18, 2013
Merged

Add soft_write_failure to puppetdb.conf #89

merged 3 commits into from
Oct 18, 2013

Conversation

ghoneycutt
Copy link
Contributor

This supports a recently added feature to PuppetDB.

This supports a recently added feature to PuppetDB.
@kbarber-jenkins2
Copy link

Can one of the admins verify this patch?

@ghoneycutt
Copy link
Contributor Author

@kbarber This should make the availability of this functionality more transparent.

@kbarber
Copy link
Contributor

kbarber commented Oct 18, 2013

test this please

class puppetdb::master::puppetdb_conf (
$server = 'localhost',
$port = '8081',
$soft_write_failure = false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this new parameter, following current convention should be exposed in puppetdb::master::config as well. Which warrants an update to the documentation in the README.md also.

@kbarber-jenkins2
Copy link

Merged build triggered.

@kbarber-jenkins2
Copy link

Merged build started.

@kbarber-jenkins2
Copy link

Merged build finished.

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/270/

@kbarber
Copy link
Contributor

kbarber commented Oct 18, 2013

@ghoneycutt let me look into that failure, its not your code at least.

@kbarber
Copy link
Contributor

kbarber commented Oct 18, 2013

retest this please

@kbarber-jenkins2
Copy link

Merged build triggered.

@kbarber-jenkins2
Copy link

Merged build started.

@kbarber-jenkins2
Copy link

Merged build finished.

@kbarber-jenkins2
Copy link

Test PASSed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/273/

kbarber added a commit that referenced this pull request Oct 18, 2013
Add soft_write_failure to puppetdb.conf
@kbarber kbarber merged commit 39e8f6c into puppetlabs:master Oct 18, 2013
@ghoneycutt ghoneycutt deleted the soft_write_failure branch October 18, 2013 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants