Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-93) Switch to using puppetlabs-postgresql 3.x #94

Merged

Conversation

kbarber
Copy link
Contributor

@kbarber kbarber commented Oct 21, 2013

This updates the module to be able to use puppetlabs-postgresql.

Since this change is a major change, it marks this patch as a breaking change.

I have prepared a suitable amount of upgrade notes for upgrading to this later
version of the module plus removed anything marked deprecated.

As cleanup, I've removed the troublesome 'tests' directory in favour of good
README.md documentation. I've also removed any puppet docs from each module
until such times as puppet docs become automated through the forge. This is
just to avoid contributors having to double their efforts - the README.md
is the authority now.

Signed-off-by: Ken Barber ken@bob.sh

This updates the module to be able to use puppetlabs-postgresql.

Since this change is a major change, it marks this patch as a breaking change.

I have prepared a suitable amount of upgrade notes for upgrading to this later
version of the module plus removed anything marked deprecated.

As cleanup, I've removed the troublesome 'tests' directory in favour of good
README.md documentation. I've also removed any puppet docs from each module
until such times as puppet docs become automated through the forge. This is
just to avoid contributors having to double their efforts - the README.md
is the authority now.

Signed-off-by: Ken Barber <ken@bob.sh>
@@ -0,0 +1,5 @@
Puppet Firewall Module - Puppet module for managing Firewalls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?

Signed-off-by: Ken Barber <ken@bob.sh>
@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/281/

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/282/

@kbarber
Copy link
Contributor Author

kbarber commented Oct 22, 2013

Looking into this failure today.

Signed-off-by: Ken Barber <ken@bob.sh>
@kbarber-jenkins2
Copy link

Test PASSed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/285/

Signed-off-by: Ken Barber <ken@bob.sh>
@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/286/

@kbarber
Copy link
Contributor Author

kbarber commented Oct 22, 2013

retest this please

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/287/

@kbarber
Copy link
Contributor Author

kbarber commented Oct 26, 2013

retest this please

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/292/

@kbarber
Copy link
Contributor Author

kbarber commented Oct 26, 2013

This is annoying, I'm seeing transient issues.

@kbarber
Copy link
Contributor Author

kbarber commented Oct 26, 2013

retest this please

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/293/

The tests were failing on Ubuntu, and I noticed that the OOM killer
was killing java. This patch increases the memory size for each
image to avoid this.

Signed-off-by: Ken Barber <ken@bob.sh>
This is to avoid any time slew problems related to ntp shifting the time
later on in the background.

Signed-off-by: Ken Barber <ken@bob.sh>
@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/295/

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/296/

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/298/

@kbarber
Copy link
Contributor Author

kbarber commented Oct 26, 2013

retest this please

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/300/

@kbarber
Copy link
Contributor Author

kbarber commented Oct 27, 2013

retest this please

@kbarber-jenkins2
Copy link

Test FAILed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/301/

Signed-off-by: Ken Barber <ken@bob.sh>
@kbarber-jenkins2
Copy link

Test PASSed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/303/

@kbarber
Copy link
Contributor Author

kbarber commented Oct 27, 2013

wow - its working. lets try again.

@kbarber
Copy link
Contributor Author

kbarber commented Oct 27, 2013

retest this please

@kbarber-jenkins2
Copy link

Test PASSed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/304/

@kbarber
Copy link
Contributor Author

kbarber commented Oct 27, 2013

retest this please

@kbarber-jenkins2
Copy link

Test PASSed.
Refer to this link for build results: http://box.bob.sh:8080/job/puppetlabs-puppetdb/305/

@kbarber kbarber mentioned this pull request Oct 27, 2013
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this actually filled in with 2013 PuppetLabs, or Debian complain. :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh never mind, saw the NOTICE instead.

apenney pushed a commit that referenced this pull request Oct 28, 2013
@apenney apenney merged commit 97dd235 into puppetlabs:master Oct 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants