Do not stop RabbitMQ before creating the Erlang Cookie #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When boostraping a cluster, Puppet will: * create the cookie and manage permissions * if there is a change on this resource (create or update), thanks to the notify in rabbitmq::config, RabbitMQ service will be restarted by Puppet. Given that, we should not manage the service in the provider itself, since it's already done in the manifest. This patch aims to delete the 'puppet resource' command in the rabbitmq_erlang_cookie provider that ensured RabbitMQ service was stopped before the cookie file management.
EmilienM
pushed a commit
to redhat-openstack/openstack-puppet-modules
that referenced
this pull request
Feb 6, 2015
This patch is temp and will be updated voxpupuli/puppet-rabbitmq#306 merged.
|
This patch is related to PDB-1223 |
|
If you run the acceptance tests, you can see this causes serious problems with the rabbitmq-server. If the cookie changes while the server is still running, it becomes unable to connect to itself and therefore unable to restart itself. An alternative to using the puppet resource command would be stopping the service via the init system. This means dealing with all supported init systems and all possible service names, so using the puppet resource command is much simpler. |
|
|
Closing due to inactivity and the concerns raised by @cmurphy. Feel free to open a new PR Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When boostraping a cluster, Puppet will:
the notify in rabbitmq::config, RabbitMQ service will be restarted by
Puppet.
Given that, we should not manage the service in the provider itself,
since it's already done in the manifest.
This patch aims to delete the 'puppet resource' command in the
rabbitmq_erlang_cookie provider that ensured RabbitMQ service was
stopped before the cookie file management.
This patch has been tested on a new environment and an existing one, to be sure RabbitMQ is updated with the right cookie, on both use-cases.