Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-reboot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-reboot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.0.1
Choose a head ref
  • 8 commits
  • 5 files changed
  • 6 contributors

Commits on Feb 24, 2021

  1. (MODULES-10955) More robust handling of reboot-task output 

    The reboot task (that gets run in line 30) always returns the status and timeout. The timeout is (per definition) the max between 3 and $reboot_delay.
No real dynamic output that is generated by the reboot task is used in the plan.

Hence: We can default to a $wait for the maximum of 3 or $reboot_delay. This way it does not matter to the plan what the reboot task runs.
So broadcast-messages (and possibly other things) do not interfere with the parsing of the timeout.
    @fetzerms
    fetzerms authored Feb 24, 2021
    Configuration menu
    Copy the full SHA
    926ee5e View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Merge pull request #276 from puppetlabs/release-prep 

    Release prep v4.0.0
    @david22swan
    david22swan authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    7571a25 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Merge pull request #280 from fetzerms/MODULES-10955 

    (MODULES-10955) More robust handling of reboot-task output
    @david22swan
    david22swan authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    494eff6 View commit details
    Browse the repository at this point in the history

  2. (MAINT) Normalize Windows OS name in metadata.json

    Ciaran McCrisken committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    26f1a79 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. Changed to ctrl::sleep() and removed redundant reboot::sleep() function

    @fetzerms
    fetzerms committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    e6a9dd9 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Merge pull request #282 from sanfrancrisko/maint/main/normalise_win_o… 

    …s_name_metadata

(MAINT) Normalize Windows OS name in metadata.json
    @pmcmaw
    pmcmaw authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    52bfd71 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #284 from fetzerms/remove_reboot_sleep 

    Cleanup: Changed to ctrl::sleep() and removed redundant reboot::sleep() function
    @pmcmaw
    pmcmaw authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    c2617b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Release prep v4.0.1

    @actions-user
    actions-user committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    40066de View commit details
    Browse the repository at this point in the history
Loading