[MODULES-8718] Check for root or sudo in the reboot task nix.sh script #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
reviewed
Mar 5, 2019
|
Thanks @thilinapiy. I'll squash the commits for you today and then merge it for you! Thanks again for your contribution!! |
Since reboot task is running shutdown command on a nohup, if its run as a normal user it will silently fail. This commit will avoid that this error.
|
@thilinapiy I've squashed all the commits together and will merge once the tests go green! |
|
AND MERGED!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since reboot task is running shutdown command on a nohup, if its run as a normal user it will silently fail. This change will avoid that.