Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULES-8726: Ensure sbin is in the path #205

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

xalimar
Copy link

@xalimar xalimar commented Mar 6, 2019

The shutdown command is usually in /sbin or /usr/sbin. Many normal
users don't already have them in their path.

Running bolt task run reboot -n somenode --run-as root doesn't reboot
the server, but does return a success.

Add /usr/sbin and /sbin to the path in the nix.sh script

The shutdown command is usually in /sbin or /usr/sbin.  Many normal
users don't already have them in their path.

Running bolt task run reboot -n somenode --run-as root doesn't reboot
the server, but does return a success.

Add /usr/sbin and /sbin to the path in the nix.sh script
@nicklewis
Copy link
Contributor

Should we make the same change to last_boot_time_nix.sh, since it uses the reboot command which is also in sbin?

@xalimar
Copy link
Author

xalimar commented Mar 6, 2019

Should we make the same change to last_boot_time_nix.sh, since it uses the reboot command which is also in sbin?

I believe that script just uses the last command (looking for a reboot). On my system last is in /usr/bin so it works, but I'm not sure if that's ever different.

@nicklewis
Copy link
Contributor

Ahh, I misread that command. That sounds right then. 👍

@thilinapiy
Copy link
Contributor

Are we going to merge this or so?

@nicklewis nicklewis merged commit 898f78d into puppetlabs:master Mar 21, 2019
@LukasAud LukasAud added the bugfix label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants