Fix reboot message for linux hosts #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting the PR @nmaludy . |
|
@sheenaajay i resolved the merge conflict in the CHANGELOG, should be good to go now. |
|
|
|
Thank you @nmaludy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Linux hosts that were rebooted with a warning message didn't have their message displayed unless the reboot delay was >= 60 seconds.
Looks like this is a race condition with the way
shutdown -r +0 "my message"works because that doesn't work on the CLI either when i tried it.On the CLI manually i was able to get the message to display by doing:
wall "my message"; shutdown -r +0.To fix this problem i checked to see if we're waiting for < 1 minute (ie. using the
sleepcommand to wait) and if so run awall "$message"before executing the shutdown. This way the message will be displayed.