Add shutdown_only parameter to tasks
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a Reboot::Task class for testing with rspec. Adds ✨ automated tests ✨ for the task 😮
Adds the `shutdown_only` parameter which allows shutting down of servers without a reboot (for decommissioning workflows, cloud etc).
|
This tries to pick up #176. |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=========================================
+ Coverage 47.49% 50.8% +3.31%
=========================================
Files 5 6 +1
Lines 259 309 +50
=========================================
+ Hits 123 157 +34
- Misses 136 152 +16
Continue to review full report at Codecov.
|
dylanratcliffe
approved these changes
Dec 4, 2019
|
Instead of 'shutdown_only', how about 'action' => shutdown|reboot? Would also allow for alternatives like log only or fail/skip remainder of catalogue. |
DavidS
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
shutdown_onlyparameter which allows shutting down of servers without a reboot (for decommissioning workflows, cloud etc).Adds ✨ automated unit tests ✨ for the task 😮