(MODULES-10955) More robust handling of reboot-task output #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reboot task (that gets run in line 30) always returns the status and timeout. The timeout is (per definition) the max between 3 and $reboot_delay. No real dynamic output that is generated by the reboot task is used in the plan. Hence: We can default to a $wait for the maximum of 3 or $reboot_delay. This way it does not matter to the plan what the reboot task runs. So broadcast-messages (and possibly other things) do not interfere with the parsing of the timeout.
|
|
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
===========================================
- Coverage 81.52% 49.68% -31.85%
===========================================
Files 6 6
Lines 314 314
===========================================
- Hits 256 156 -100
- Misses 58 158 +100
Continue to review full report at Codecov.
|
|
The decrease in code coverage seems to be from windows.rb, which I did not touch. Anything else that needs to be done, in order to get this PR merged? |
pmcmaw
approved these changes
Mar 4, 2021
david22swan
approved these changes
Mar 4, 2021
|
@fetzerms Thank you for your change and sorry it took a while to get around to merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reboot task (that gets run in line 30) always returns the status and timeout. The timeout is (per definition) the max between 3 and $reboot_delay. No real dynamic output that is generated by the reboot task is used in the plan.
Hence: We can default to a $wait for the maximum of 3 or $reboot_delay. This way it does not matter to the plan what the reboot task runs. So broadcast-messages (and possibly other things) do not interfere with the parsing of the timeout.