Cleanup: Changed to ctrl::sleep() and removed redundant reboot::sleep() function

[fetzerms]

Bolt comes with a built-in sleep function (since at least two years, according to git). The reboot::sleep() function seems to be redundant. It does not do anything more or special than the built-in one. Hence: I think we can remove it and use the built-in method for better maintainability.

I did not (yet?) create a MODULES-Issue for it, as it is just a minor code quality improvement and not really an issue or a feature to be requested. If a Jira-issue needs to be created, I can still do it tho.

[codecov-io]

Codecov Report

Merging #284 (e6a9dd9) into main (494eff6) will increase coverage by 2.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   81.52%   83.66%   +2.13%     
==========================================
  Files           6        5       -1     
  Lines         314      306       -8     
==========================================
  Hits          256      256              
+ Misses         58       50       -8     

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494eff6...e6a9dd9. Read the comment docs.

[pmcmaw]

Thanks for this PR! Great spot!
I would like to thank you for your time and effort on getting this over the line.
Merging.

Adding the documentation for ctrl:sleep that is built in to bolt: https://puppet.com/docs/bolt/latest/plan_functions.html#ctrlsleep

[fetzerms]

Thank you very much for merging @pmcmaw . Is there a fixed schedule, when new releases will be published to puppet forge?

[pmcmaw]

Yes, we have a partially automated process now. So over the weekend, if there have been any changes to main since the last release, release prep will automatically be created. This will then be picked up on Monday as part of our Community Day and the module released.

[fetzerms]

Thanks for the explanation. Great! I am happy to receive the latest fixes via forge soon :-)

[pmcmaw]

This module was released onto the Forge yesterday and includes your changes, thank you for your contributions to Puppet :-)