(MODULES-11149) Modify result of 'last' to remove current time #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmburgan
force-pushed
the
maint/main/modify_last_boot_tim_nix
branch
from
eb9a9dd
to
26bf55b
Compare
|
Tested on all the platforms listed on https://puppet.com/docs/pe/2021.2/patch_management_setup.html. This appears to affect RedHat-based 6/7 (centos, RHEL, Scientific, Oracle) as well as SLES 12. Other platforms just have |
When doing 'last -1 reboot', the end of this line will show the current time, since it shows both the start and end time of the session. Since the plan is simply comparing the raw string to see if we've rebooted, this makes it think we've always rebooted, since the end of this string changes every second. This commit slices off the end time, leaving only the login time.
nmburgan
force-pushed
the
maint/main/modify_last_boot_tim_nix
branch
from
26bf55b
to
df65573
Compare
nmburgan
changed the title
daianamezdrea
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing 'last -1 reboot', the end of this line will show the current time on some platforms, since it shows both the start and end time of the session. Since the plan is simply comparing the raw string to see if we've rebooted, this makes it think we've always rebooted, since the end of this string changes every second. This commit slices off the end time, leaving only the login time.