(maint) Fix typo causing specs to fail in 1.9.3p125
Without this patch there are two minor typographical errors in the registry_key and registry_value Type spec tests. This patch corrects the typo and gets the spec tests passing on 1.9.3p125.
Merge branch 'maint/master/fix_spec_failures_in_193'
* maint/master/fix_spec_failures_in_193: (maint) Fix typo causing specs to fail in 1.9.3p125
(#14149) Move utility code to puppet_x convention
This patch is a simple rename only change in preparation for the real patch of migrating Puppet::Modules::Registry to PuppetX::Puppetlabs::Registry
(#14149) Refactor utility code into PuppetX namespace
Without this patch the registry module is a bad example for contributors and module authors because it does not follow the PuppetX convention described at Puppet Design Guidelines [1] This patch fixes the problem by moving all of the utility code and mix-in modules from Puppet::Modules::Registry to PuppetX::Puppetlabs::Registry namespace. In addition, the loading code (require statements) have been modified to assume #7788 (rubygems support) is implemented. In the scenario where 7788 is not yet implemented we fall back to the work around of requiring fully qualified paths to operate with pluginsync as described in #14073. [1] http://projects.puppetlabs.com/projects/puppet/wiki/Puppet_Design_Guidelines
Merge pull request #18 from jeffmccune/maint/master/use_puppet_x_conv…
…ention (#14149) Refactor utility code into PuppetX namespace
(Maint) Fix unhandled exception working around #4248
Without this patch applied the Puppet master will error out because of an uncaught exception trying to load utility code. This is a problem because the registry types and providers cause catalog compilation to fail. The root cause of this problem is that require without an exception class will default to a behavior that does not catch LoadError exceptions. This patch fixes the problem by explicitly catching LoadError and re-raising if the work-around fails.
Merge branch 'fix/master/14149_fix_exception_handler'
* fix/master/14149_fix_exception_handler: (Maint) Fix unhandled exception working around #4248 Paired-with: Andrew Parker <andy@puppetlabs.com>
Remove debugger statement. Whoops.
Updated content to conform to README best practices template
Before alterations, this content was the module author- determined description of and instructions for use of the module. As part of a joint Forge/Docs team effort to standardize formatting and encourage quality module documentation, a best practices README template was created via internal and external user testing. That template was then applied to this module. I pulled in content from the original README on GitHub and in-code comments. Standard headings were added (Overview, Module Description, Setup, Usage, etc.) to organize content, existent content was moved under its appropriate heading and edited for tone/flow/clarity, and basic formatting was done to adhere to template standards. I chose to leave off a Reference section as all bits of the inner workings of the module are called out and discussed under Usage.
This class is largely empty BUT serves a purpose, as @jeffmccune explained to me. Updated the documentation in the header to reflect this information.
Remove incorrect information, update phrasing, insert backslashes, an…
…d fix typos/capitalization errors This update fixes capitalization and typographical errors, removes incorrect information (the inclusion of "services" specifically), updates the phrasing, and inserts backslashes where they were missing.
Merge pull request #21 from laurenrother/README-update
Readme update
Only try to manage redirected registry keys/values on x64 systems
Previously, the acceptance test was trying to manage redirected keys and values on x86 and x64 systems. However, on x86 systems, both 32:HKLM and HKLM refer to the same key. As a result, only one 'created' message was output for each pair of key/values, causing the acceptance test to fail. This commit ensures we only test the redirected keys/values, those prefixed with '32:' when run on x64 systems.
Detect whether sysnative filesystem alias is available
Previously the test assumed that the sysnative filesystem alias was available, so that we could run the 64-bit version of reg.exe. However, this fails when running on x86 versions of Windows. It also fails when running on x64 on 2003, as the sysnative alias is not available until Vista and later. This commit logs a warning if the sysnative alias is not available on x64 systems. Otherwise, it uses the 'native' version of reg.exe to check for the default registry value.
Merge pull request #22 from joshcooper/maint/master/fix-acceptance-on…
…-32-bit Fix acceptance tests when running on 32-bit version of 2003
* DavidS-master: Add geppetto project file closes #23
Refactor class variable usage in registry_value
Without this commit the provider for the registry_value type was using a class instance variable. The purpose of this variable was to share a single instance of a `Win32API` object between all provider instances. The method of accessing this shared object from the provider instances was to call the class variable with '@@' prepended. Starting with Ruby 1.9, use of this method is considered harmful and now causes a warning to be rasied. This commit adds an accessor class method to replace accessing the class instance variable directly. The call that originally accessed the class variable has been refactored to use the accessor method of the class.
Merge pull request #26 from hunner/add_travis
Add travis support and update specs for rspec 2.14
Merge pull request #25 from trlinkin/class_variable_fix
Refactor class variable usage in registry_value
Summary: This is a bugfix release that allows the module to work more reliably on x64 systems and on older systems such as 2003. Also fixes compilation errors due to windows library loading on *nix masters. Bugfixes: - Fixed specs against newer rspec and added travis - Refactored code into PuppetX namespace - Fixed unhandled exception when loading windows code on *nix - Updated README and manifest documentation - Only manage redirected keys on 64 bit systems - Only use /sysnative filesystem when available - Use class accessor method instead of class instance variable - Add geppetto project file
Merge pull request #28 from hunner/revert_travis
Revert "Merge pull request #26 from hunner/add_travis"
Merge pull request #29 from hunner/revert_0.1.2
Revert "Merge pull request #27 from hunner/release_0.1.2"
Summary: This is a bugfix release that allows the module to work more reliably on x64 systems and on older systems such as 2003. Also fixes compilation errors due to windows library loading on *nix masters. Bugfixes: - Refactored code into PuppetX namespace - Fixed unhandled exception when loading windows code on *nix - Updated README and manifest documentation - Only manage redirected keys on 64 bit systems - Only use /sysnative filesystem when available - Use class accessor method instead of class instance variable - Add geppetto project file
Merge pull request #33 from apenney/license
Add a license file.
Updates README to reflect current module capabilities
Updates sections of README to reflect current module functions. Edits for clarity, spelling, grammar, formatting and consistency.
Merge pull request #38 from laurenrother/readme
Updates README to reflect current module capabilities
Adds "Release Notes/Known Bugs" to Changelog, updates file format to …
…markdown, standardizes the format of previous entries Per a request to have initial release notes that specifically listed known issues for this PE 3.2 release, and barred by time constraints from automating a pull from open issues in JIRA, this commit adds a Release Note and Known Bug section to the Changelog for the imminent 3.2 release. As it will display on the Forge, updates file type to markdown and standardizes previous entries.
Merge pull request #41 from laurenrother/changelog2
Adds "Release Notes/Known Bugs" to Changelog, updates file format to markdown, standardizes the format of previous entries
Merge pull request #39 from adreyer/master
bump for 1.0.0 release with proper metadata for forge
Summary This is a supported release. Bugfixes - Documentation updates - Add license file Known Bugs * This module does not work if run as non-root. Please see [PE-2772](https://tickets.puppetlabs.com/browse/PE-2772)