Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-7937) Implement Puppet Strings #107

Merged
merged 3 commits into from
May 7, 2019
Merged

Conversation

carabasdaniel
Copy link
Contributor

No description provided.

Copy link
Contributor

@eimlav eimlav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes @carabasdaniel .

REFERENCE.md Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
@@ -24,13 +23,14 @@
# @param verify_satellite_certificate [Boolean] When set to false, allows the Satellite server to present an unsigned, unrecognized,
# or invalid SSL certificate. This creates the risk of a host falsifying its identity as the Satellite server.
# Valid values: true, false. Defaults to true.
# @param ssl_ca [Optional[String]] The file path to the CA certificate used to verify the satellite server identitity. If not
# @param ssl_ca [String] The file path to the CA certificate used to verify the satellite server identitity. If not
# provided, the local Puppet Enterprise master's CA is used.
# @param ssl_cert [String] The file path to the certificate signed by the Satellite CA. It's used for Satellite to verify the identity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data type automatically extracted. This should be removed.

manifests/init.pp Outdated Show resolved Hide resolved
@@ -24,13 +23,14 @@
# @param verify_satellite_certificate [Boolean] When set to false, allows the Satellite server to present an unsigned, unrecognized,
# or invalid SSL certificate. This creates the risk of a host falsifying its identity as the Satellite server.
# Valid values: true, false. Defaults to true.
# @param ssl_ca [Optional[String]] The file path to the CA certificate used to verify the satellite server identitity. If not
# @param ssl_ca [String] The file path to the CA certificate used to verify the satellite server identitity. If not
# provided, the local Puppet Enterprise master's CA is used.
# @param ssl_cert [String] The file path to the certificate signed by the Satellite CA. It's used for Satellite to verify the identity
# of the Puppet Enterprise master
# @param ssl_key [String] The file path to the key for the Puppet Enterprise master generated by Satellite
# @param manage_default_ca_cert [Boolean] Applicable to Red Hat-based systems only. When set to true, the module transfers the Satellite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data type automatically extracted. This should be removed.

@eimlav eimlav added the feature label May 7, 2019
@carabasdaniel carabasdaniel requested a review from eimlav May 7, 2019 12:34
manifests/init.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
@eimlav eimlav changed the title [FM-7937] Puppet Strings (FM-7937) Implement Puppet Strings May 7, 2019
@eimlav eimlav merged commit fefd8d1 into puppetlabs:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants