(IAC-1008) - Removal of Inappropriate Terminology

[david22swan]

Removal of any offensive or inappropritate terminology from the code base

[puppet-community-rangefinder]

satellite_pe_tools is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (main@edf25e0). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main    #148   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       5           
  Lines           ?     206           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?     206           
  Partials        ?       0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf25e0...1f2177c. Read the comment docs.

[david22swan]

@ekohl Thanks for your comments :)
Think I've resolved them all

[david22swan]

@ekohl Thank you for the updated comments, have made the suggested changes.

[ekohl]

Looking at

puppetlabs-satellite_pe_tools/manifests/init.pp

Lines 20 to 22 in edf25e0

	# @param ssl_cert The file path to the certificate signed by the Satellite CA. It's used for Satellite to verify the identity
	# of the Puppet Enterprise master
	# @param ssl_key The file path to the key for the Puppet Enterprise master generated by Satellite

it does suggest that this is a pair. However, this commit isn't very clear in why:

9446834

The fact we can't figure it out with documentation is not a good sign for this module.

[michaeltlombardi]

LGTM