report processor: load utils via absolute path #180
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
require
branch
2 times, most recently
from
deb204a
to
7b033c1
Compare
ekohl
reviewed
May 13, 2022
Fixes puppetlabs#179 This fix is based on a slack conversation with Josh Cooper: > Extensions like termini need to use require_relative to load helper code, because when running in a server context the environment specific directory is not added to the ruby LOAD_PATH.Or resolve the absolute path at runtime like https://github.com/puppetlabs/puppetlabs-splunk_hec/blob/6f2cd7beaddba20015a5d3833dacd79705b2d877/lib/puppet/indirector/facts/splunk_hec.rb#L3
chelnak
approved these changes
Jul 18, 2022
|
Spec failures are not related to the work in this PR - Happy to merge. Thanks for your contribution @bastelfreak |
|
@chelnak thanks for merging. Can you also prep a new release? |
|
Yeah I will do shortly. I would prefer it if the spec tests were green before I cut a new release. I'm going to look at them now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#179
This fix is based on a slack conversation with Josh Cooper: