-
Notifications
You must be signed in to change notification settings - Fork 35
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-scheduled_task
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.3.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: puppetlabs/puppetlabs-scheduled_task
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.3.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 9 files changed
- 5 contributors
Commits on Dec 16, 2020
-
Merge pull request #173 from puppetlabs/release
Release version 2.3.0
Configuration menu - View commit details
-
Copy full SHA for 106d092 - Browse repository at this point
Copy the full SHA 106d092View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4562342 - Browse repository at this point
Copy the full SHA 4562342View commit details -
Merge pull request #176 from puppetlabs/maint/main/fix_provision_yaml
(MAINT) Remove errant comma from provision.yaml merged
Configuration menu - View commit details
-
Copy full SHA for 3290187 - Browse repository at this point
Copy the full SHA 3290187View commit details -
(MODULES-10893) Fix Last Day Of Month Trigger
Prior to this change, attempting to create a trigger that will run on the last day of each selected month will fail. The error claims that a a value is out of range ``` OLE error code:0 in <Unknown> <No Description> HRESULT error code:0x8002000a Out of present range. ``` Microsoft [documentation] claims in one place that the correct way to specify the last day of a month is to effectively translate a bitmask value of day 32 and pass that into the `{get:set}_DaysOfMonth` method on the trigger object. The module was previously coded to do exactly this. The provider and it's helpers would catch the string value 'last' in the `on` property of a `monthly` trigger and translate it into the bit mask. This is what resulted in the error, because it turns out that the position for day 32 in the bit mast is outside the acceptable range of values for this property. This PR changes strategy and instead relies on a different section of the documentation in which an entirely different property on the trigger object called [RunOnLastDayOfMonth] is set. The code now catches the string value 'last' in the `on` property of the trigger, and sets this boolean on the trigger object. Testing has shown this to be an effective method of managing this property of a trigger. [documentation]: https://docs.microsoft.com/en-gb/windows/win32/api/taskschd/nf-taskschd-imonthlytrigger-get_daysofmonth [RunOnLastDayOfMonth]: https://docs.microsoft.com/en-gb/windows/win32/api/taskschd/nf-taskschd-imonthlytrigger-put_runonlastdayofmonthConfiguration menu - View commit details
-
Copy full SHA for 779908b - Browse repository at this point
Copy the full SHA 779908bView commit details
Commits on Dec 18, 2020
-
Merge pull request #175 from RandomNoun7/MODULES-10893-fix-last-day-o…
…f-month (MODULES-10893) Fix Last Day Of Month Trigger
Configuration menu - View commit details
-
Copy full SHA for 46bf890 - Browse repository at this point
Copy the full SHA 46bf890View commit details -
Auto-release committed
Dec 18, 2020 Configuration menu - View commit details
-
Copy full SHA for a6b3ee6 - Browse repository at this point
Copy the full SHA a6b3ee6View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.3.0...v2.3.1