(IAC-918) - disable_time_zone_synchronization function implemented
#145
Conversation
scheduled_task is a typeBreaking changes to this file MAY impact these 10 modules (near match):This module is declared in 0 of 575 indexed public
|
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 95.42% 95.31% -0.11%
==========================================
Files 6 6
Lines 830 833 +3
==========================================
+ Hits 792 794 +2
- Misses 38 39 +1
Continue to review full report at Codecov.
|
lib/puppet/type/scheduled_task.rb
Outdated
| @@ -140,6 +140,8 @@ def insync?(current) | |||
| * `minutes_interval` --- The repeat interval in minutes. | |||
| * `minutes_duration` --- The duration in minutes, needs to be greater than the | |||
| minutes_interval. | |||
| * `disable_synchronise` --- Whether or not to disable the `synchronise across | |||
There was a problem hiding this comment.
I would be tempted to name it something a bit more in line with the Windows functionality it's controlling. Perhaps time_zone_synchronization, or better still, exactly as it is in the UI: synchronize_across_time_zones. I will admit that's a bit long, but it will make it obvious what it's related to.
There was a problem hiding this comment.
Changed to disable_time_zone_synchronization. synchronize_across_time_zones doesn't really work due to the function turning it of rather than varying it or turning it on.
| apply_manifest(pp, catch_failures: true) | ||
|
|
||
| # Ensure it's idempotent | ||
| # apply_manifest(pp, catch_changes: true) |
There was a problem hiding this comment.
Can this be deleted?
There was a problem hiding this comment.
Removed and added a note to the type to show that it is non-idempotent
| apply_manifest(pp, catch_failures: true) | ||
|
|
||
| # Ensure it's idempotent | ||
| # apply_manifest(pp, catch_changes: true) |
There was a problem hiding this comment.
Can this be deleted?
There was a problem hiding this comment.
Removed and added a note to the type to show that it is non-idempotent
david22swan
changed the title
disable_synchronise function implementeddisable_time_zone_synchronization function implemented
sanfrancrisko
changed the title
disable_time_zone_synchronization function implementeddisable_time_zone_synchronization function implemented
No description provided.