Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10783) Add back empty? check for datetime_string value #158

Merged
merged 1 commit into from
Aug 24, 2020
Merged

(MODULES-10783) Add back empty? check for datetime_string value #158

merged 1 commit into from
Aug 24, 2020

Conversation

sanfrancrisko
Copy link
Contributor

In #145 it
looks as though we removed the empty check on datetime_string.

This was causing the PE Patch Management tasks to fail in PE 2019.8.1.

In #145 it
looks as though we removed the empty check on `datetime_string`.

This was causing the PE Patch Management tasks to fail in PE 2019.8.1.
@sanfrancrisko sanfrancrisko requested a review from a team as a code owner August 24, 2020 13:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2020

Codecov Report

Merging #158 into main will increase coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files           6        6           
  Lines         835      836    +1     
=======================================
+ Hits          793      794    +1     
  Misses         42       42           
Impacted Files Coverage Δ
lib/puppet_x/puppetlabs/scheduled_task/trigger.rb 94.77% <80.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f4874...8857b1c. Read the comment docs.

@sanfrancrisko sanfrancrisko changed the title (MODULES-10783) Add check for potentially empty datetime_string value (MODULES-10783) Add back empty? check for datetime_string value Aug 24, 2020
@sanfrancrisko
Copy link
Contributor Author

Release checks:

image

@sheenaajay sheenaajay merged commit 51d5150 into puppetlabs:main Aug 24, 2020
@sanfrancrisko sanfrancrisko deleted the fix/MODULES-10783 branch August 24, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants