Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bugfix) - fix disable_time_zone_synchronization so that it correctly disables functionality when set to true #161

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Aug 25, 2020

No description provided.

…ly disables functionality when set to true
@david22swan david22swan requested a review from a team as a code owner August 25, 2020 16:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #161 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files           6        6           
  Lines         836      836           
=======================================
  Hits          794      794           
  Misses         42       42           
Impacted Files Coverage Δ
lib/puppet_x/puppetlabs/scheduled_task/trigger.rb 94.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a1622...40bd93b. Read the comment docs.

@david22swan david22swan changed the title (bugfix) - fix disable_time_zone_synchronization so that it correct… (bugfix) - fix disable_time_zone_synchronization so that it correctly disables functionality when set to true Aug 25, 2020
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should take a look at what the test coverage here given we've got 2 fixes going in to this functionality in as many days?

Would be happy for this to be merged for now, to get the fix out there, but I think we need to look at the test coverage.

If we think enhancing the tests is quick, then let's do it, otherwise we can merge and raise a ticket to address after.

@sanfrancrisko sanfrancrisko merged commit a8b8085 into puppetlabs:main Aug 25, 2020
@david22swan david22swan deleted the sync_fix branch August 26, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants